Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security issues #85

Open
ghoshbishakh opened this issue Apr 9, 2019 · 11 comments
Open

Fix security issues #85

ghoshbishakh opened this issue Apr 9, 2019 · 11 comments
Assignees

Comments

@ghoshbishakh
Copy link
Member

No description provided.

@JayjeetAtGithub
Copy link

JayjeetAtGithub commented Apr 9, 2019

@Compro-Prasad @ghoshbishakh Can you please brief me about this issue ?

@Compro-Prasad
Copy link
Collaborator

@JayjeetAtGithub The npm audit fix which we were unable to do successfully. I found the issue to be in vue-paginate which we will have to replace. So, basically you need to remove vue-paginate from the project and make a paginate component yourself. If you are busy, then I can do it myself. Just confirm.

@JayjeetAtGithub
Copy link

I and @realsdx can work on it together, then it will be easier for both of us.

@realsdx
Copy link
Member

realsdx commented Apr 9, 2019

Screenshot from 2019-04-09 23-52-12
This might help, but any vulnerability currently present in dependencies doesn't effect the website. Its non-applicable in current setup/code. But, as a good security practice we should Update always.

@realsdx
Copy link
Member

realsdx commented Apr 9, 2019

Can we use any other pagination library ? if updating it is problematic

@Compro-Prasad
Copy link
Collaborator

Compro-Prasad commented Apr 10, 2019

Its not hard to make a pagination component. There is a blog post on it: https://medium.com/@denny.headrick/pagination-in-vue-js-4bfce47e573b

Else we might try https://github.com/lokyoung/vuejs-paginate

@JayjeetAtGithub
Copy link

@Compro-Prasad I will try to make one pagination component....Let' see.

@ghoshbishakh
Copy link
Member Author

why can't we update?

@Compro-Prasad
Copy link
Collaborator

why can't we update?

Back before when I tried, there wasn't one. We could try again.

@Compro-Prasad
Copy link
Collaborator

Pinging @arc9693

@Compro-Prasad
Copy link
Collaborator

I would also like to present my observations as written in this comment. It might be correct observation but I am not sure about it.

@Compro-Prasad Compro-Prasad pinned this issue Jun 18, 2019
@rohitsh16 rohitsh16 unpinned this issue Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants