From af446d22ce9e54b2074a2107b1e18c11581a2722 Mon Sep 17 00:00:00 2001 From: Luca Di Grazia Date: Sun, 4 Sep 2022 19:41:41 +0200 Subject: [PATCH] Flip --incompatible_objc_framework_cleanup flag to true RELNOTES[INC]: cleanup that affects user provided apple frameworks is now enabled by default. See https://github.com/bazelbuild/bazel/issues/7944 for more info. PiperOrigin-RevId: 250743310 --- .../devtools/build/lib/packages/StarlarkSemanticsOptions.java | 4 +++- .../google/devtools/build/lib/syntax/StarlarkSemantics.java | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java index cce394667af..56b64015b25 100644 --- a/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java +++ b/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java @@ -140,9 +140,11 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl + "debugging.") public boolean experimentalPlatformsApi; + // TODO(cparsons): Resolve and finalize the transition() API. The transition implementation + // function should accept two mandatory parameters, 'settings' and 'attr'. @Option( name = "experimental_starlark_config_transitions", - defaultValue = "true", + defaultValue = "false", documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS, effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS}, metadataTags = {OptionMetadataTag.EXPERIMENTAL}, diff --git a/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java index 8412a5114d9..52c703af04f 100644 --- a/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java +++ b/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java @@ -225,7 +225,7 @@ public static Builder builderWithDefaults() { .experimentalGoogleLegacyApi(false) .experimentalJavaCommonCreateProviderEnabledPackages(ImmutableList.of()) .experimentalPlatformsApi(false) - .experimentalStarlarkConfigTransitions(true) + .experimentalStarlarkConfigTransitions(false) .experimentalStarlarkUnusedInputsList(false) .incompatibleBzlDisallowLoadAfterStatement(true) .incompatibleDepsetIsNotIterable(false)