From 14f9011fe39f467feb0ab4c1b669541d7adc0ba2 Mon Sep 17 00:00:00 2001
From: Luc <8822552+luc-github@users.noreply.github.com>
Date: Fri, 19 Jan 2024 12:37:42 +0800
Subject: [PATCH] Add FIXME note

---
 main/core/esp3d_values.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/main/core/esp3d_values.cpp b/main/core/esp3d_values.cpp
index bea88c57..24658266 100644
--- a/main/core/esp3d_values.cpp
+++ b/main/core/esp3d_values.cpp
@@ -67,6 +67,8 @@ bool ESP3DValues::set_string_value(ESP3DValuesIndex index, const char* value,
       element->value = value;
       esp3d_log("Setting String value %s for %d", value, (int)index);
       if (element->callbackFn) {
+        //FIXME:Instead of immediatly use the callback function
+        //we should use a queue and call it in the loop to be sure there is no race condition
         element->callbackFn(element->index, value, action);
       }
       return true;