Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not auto-install IOTester #105

Closed
LDAP opened this issue May 4, 2021 · 2 comments
Closed

Do not auto-install IOTester #105

LDAP opened this issue May 4, 2021 · 2 comments
Milestone

Comments

@LDAP
Copy link
Contributor

LDAP commented May 4, 2021

Is your feature request related to a problem? Please describe.
We would like to use our own implementation for IO testing, as AJTS does not meet our requirements here.
AJTS does replace the System.* streams automatically, overwriting our own implementation.

Describe the solution you'd like
Do not auto-install the IOTesting replacements. Provide an annotation @EnableIOFramework (or similar) to allow own implementations.

Describe alternatives you've considered
Provide an annotaion @DisableIOFramework. But something like replacing System.* should not happen automatically.

Ares-Version you are using
1.5.3

@MaisiKoleni
Copy link
Collaborator

One possible solution is to simply uninstall the IOTester by using IOTester.uninstallCurrent(). This could e.g. be done in the setup for the custom solution for each test case. If the IOTester is uninstalled, whitelisted code can set IO to anything you want.

We want the automatic replacement of System.* to avoid blocking code and spam in the build logs / huge logs, and it never came in our way of testing and proved to be more beneficial. This is different of course if you want to use something else, in which case the uninstallation should solve the problem.

@MaisiKoleni
Copy link
Collaborator

MaisiKoleni commented Mar 24, 2022

Given the late change and #144 this fix probably is of no interest to you, but I had some time and was wondering how a solution could look like. So now there is a way to use custom IO testing code in Ares. API is experimental, so in case anyone would prefer a certain behavior of the current one, this would become subject of a new issue.

@MaisiKoleni MaisiKoleni added this to the 1.9.1 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants