[FEATURE] Add sea and other water reservoirs

[Timur-SA]

I'm not sure if I found a bug or if it's just not implemented yet.

When generating a coastal city, the sea was ignored. In fact, it would be nice to just add 1 layer of water instead of the sea, or label it some other way.

[amir16yp]

im working on it! pr soon i hope

[louis-e]

Just to add a thought here which keeps bugging me; the floodfill algorithm slows down the entire generation which such huge elements like large seas. So the timeout kills the literal floodfilling in many cases. So either we can detect a large element like a sea and increase the timeout for this specific element or make it even more performance efficient :D
Asynchronous floodfilling could also be a solution but this needs extensive testing since this could break the layering / block priority system.

[amir16yp]

Just to add a thought here which keeps bugging me; the floodfill algorithm slows down the entire generation which such huge elements like large seas. So the timeout kills the literal floodfilling in many cases. So either we can detect a large element like a sea and increase the timeout for this specific element or make it even more performance efficient :D Asynchronous floodfilling could also be a solution but this needs extensive testing since this could break the layering / block priority system.

im trying to write an element processor that would check the "international water" and "territorial water" boundaries from the OSM data then use floodfill. i will be benchmarking it using floodfill and other methods

[amir16yp]

i might have done it. gonna do some more benchmarking with bigger bbox's

[louis-e]

Great, that's amazing! Thanks a lot :)
What program are you using btw to display the Minecraft maps? I should really start using those too, joining the world in Minecraft every time takes too much time now :D

[amir16yp]

Great, that's amazing! Thanks a lot :) What program are you using btw to display the Minecraft maps? I should really start using those too, joining the world in Minecraft every time takes too much time now :D

Unmined, the gui version
https://unmined.net/

[amir16yp]

i made natural.rs handle coastlines, to make it generate oceans in coastal cities. it worked but it seems that floodfill can time out a lot and it leads to the water being incomplete.
https://github.com/amir16yp/arnis/blob/main/src/element_processing/natural.rs
needs more testing though

[louis-e]

Really cool! Take your time, looking forward to it! :)