Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Specific building/complex does not render, but is present in OSM data #112

Closed
unquietwiki opened this issue Jan 1, 2025 · 5 comments · Fixed by #165
Closed

[BUG] Specific building/complex does not render, but is present in OSM data #112

unquietwiki opened this issue Jan 1, 2025 · 5 comments · Fixed by #165
Labels
bug Something isn't working

Comments

@unquietwiki
Copy link

Describe the bug
https://www.openstreetmap.org/relation/6314332 does not render in Arnis; the pool & surrounding buildings do, however.

Used bbox area
34.024227 -118.419893 34.028798 -118.410816

Used Minecraft version
1.21.4

Screenshots
If applicable, add screenshots to help explain your problem.
2024-12-31 19_21_53-Minecraft 1 21 4 - Singleplayer

Additional context
Was able to recreate the issue in both a smaller and larger BBOX; the smaller one is stated above.

@unquietwiki unquietwiki added the bug Something isn't working label Jan 1, 2025
@unquietwiki
Copy link
Author

The trigger for this may be that it's a "multipolygon" in the OSM data, with an inner & outer layer; the surrounding buildings appear to have multiple "nodes".

@unquietwiki
Copy link
Author

// Only process multipolygons for now

Okay, so apparently, "multipolygon" data is skipped over in the current code base. So I guess that makes it a semi-known issue then.

@louis-e
Copy link
Owner

louis-e commented Jan 1, 2025

Hi there!
Sorry for the late response, this project exploded in popularity right before I planned my vacation. :D

Thank you for the report, I'll take care of fixing this as soon as possible. I can confirm that this is due to the multipolygon elements not being implemented.

Have an amazing start into the new year!

@unquietwiki
Copy link
Author

Thanks @louis-e ; I had found out about this via Hacker News, if that helps narrow down the popularity boost.

I did have an idea on how to "start" fixing this: the outer and inner are also nodes, so at the very least rendering outer nodes would be a start. I think inner nodes would have to be done on a second pass: a crude version would be to stamp out the layers inside that node range. Rust isn't a language I'm immediately familiar with, else I'd try my hand at it.

Enjoy your vacation and Happy New Year!

@unquietwiki
Copy link
Author

missing_building_fixed

Thanks @louis-e for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants