Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated nom calls #15

Open
joshrule opened this issue Apr 18, 2019 · 1 comment
Open

Deprecated nom calls #15

joshrule opened this issue Apr 18, 2019 · 1 comment

Comments

@joshrule
Copy link
Collaborator

Noticed these when compiling polytype today:

warning: use of deprecated item 'nom::methods::call_m': Please use the nom-methods crate instead
 --> /Users/rule/sync/josh/library/research/polytype-rs/src/parser.rs:2:16
  |
2 | use nom::{alt, call_m, do_parse, expr_res, map, map_res, method, opt, separated_list, tag, ws};
  |                ^^^^^^
  |
  = note: #[warn(deprecated)] on by default

warning: use of deprecated item 'nom::methods::method': Please use the nom-methods crate instead
 --> /Users/rule/sync/josh/library/research/polytype-rs/src/parser.rs:2:58
  |
2 | use nom::{alt, call_m, do_parse, expr_res, map, map_res, method, opt, separated_list, tag, ws};
  |                                                          ^^^^^^

I don't know if I'll have time to put together the PR for this so wanted to flag it here in case someone else can get to it before I do.

@lorepozo
Copy link
Owner

I took a closer look at this, seems like nom is in a somewhat inconsistent state right now, in preparation for 5.0. Probably worth restricting the version more tightly (going back to before this warning was occurring) and then upgrade to 5.0 when the time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants