Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose isActive() method in Transaction interface #3471

Closed
2 tasks done
b-admike opened this issue Jul 30, 2019 · 1 comment
Closed
2 tasks done

Expose isActive() method in Transaction interface #3471

b-admike opened this issue Jul 30, 2019 · 1 comment
Assignees
Labels
developer-experience Issues affecting ease of use and overall experience of LB users Repository Issues related to @loopback/repository package
Milestone

Comments

@b-admike
Copy link
Contributor

b-admike commented Jul 30, 2019

Steps to reproduce

Coming from #3397 (comment). We need to expose an API for transactions in LB4 to check if a transaction is active or not.

Acceptance Criteria

  • Create a isActive method in loopback-connector that checks if the connection object on a transaction is present or not, thus indicating if transaction itself is active. Add unit tests to verify the behaviour and release a new minor version of the module.
  • Include the method definition in Transaction interface in loopback-next and use it in tests and before/after hooks to check if transactions are active
@jannyHou
Copy link
Contributor

closing since all related PR merged. And see the postgresq follow-up story in loopbackio/loopback-connector-postgresql#411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Issues affecting ease of use and overall experience of LB users Repository Issues related to @loopback/repository package
Projects
None yet
Development

No branches or pull requests

3 participants