Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Sardine 5.10 to 5.12 breaks SLF4J #432

Closed
rPraml opened this issue Jul 10, 2023 · 2 comments
Closed

Update from Sardine 5.10 to 5.12 breaks SLF4J #432

rPraml opened this issue Jul 10, 2023 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@rPraml
Copy link

rPraml commented Jul 10, 2023

We use in our application SLF4J 1.7.36, but 5.12 (and also 5.11) have a dependency to SLF4J 2.0 (slf-api + slf-simple) now.

See https://repo1.maven.org/maven2/com/github/lookfirst/sardine/5.10/sardine-5.10.pom
vs. https://repo1.maven.org/maven2/com/github/lookfirst/sardine/5.12/sardine-5.12.pom

This change was introduced with
55ad2d2
I assume, that these dependencies should have the test scope.

/edit: Possible workaround: Exclude them in your own application-pom

Roland

@oliviercailloux
Copy link

oliviercailloux commented Sep 30, 2023

SLF4J recommends to not export your provider. So, slf-simple should not be marked as a transitive dependency. This can be done with the test scope, indeed.

Currently, I have to exclude slf-simple from the dependencies of Sardine.

@dkocher
Copy link
Collaborator

dkocher commented Sep 30, 2023

Would you mind to open a pull request with the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

4 participants