From 72a94fab8b6e7a2c3847bf969648ab39838c87eb Mon Sep 17 00:00:00 2001 From: Ola Okelola Date: Mon, 14 Mar 2022 23:18:11 -0700 Subject: [PATCH 1/3] debugging --- internal/graphql/generate_ts_code.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/graphql/generate_ts_code.go b/internal/graphql/generate_ts_code.go index cc8b63a9e..c748fd2d0 100644 --- a/internal/graphql/generate_ts_code.go +++ b/internal/graphql/generate_ts_code.go @@ -452,9 +452,12 @@ func searchForFiles(processor *codegen.Processor) []string { // run in root dir cmd.Dir = rootPath cmd.Stdout = &buf + cmd.Stderr = os.Stderr + // for debugging... + spew.Dump(strconv.Quote(strings.Join(searchFor, "|"))) if err := cmd.Run(); err != nil { if processor.Config.DebugMode() { - fmt.Printf("error %v searching for custom files", err) + fmt.Printf("error searching for custom files: %v\n", err) } return nil } From 2c76e7796c3f8e3a4c965f20d3a9cfb0765653a9 Mon Sep 17 00:00:00 2001 From: Ola Okelola Date: Mon, 14 Mar 2022 23:37:05 -0700 Subject: [PATCH 2/3] use combined output --- internal/graphql/generate_ts_code.go | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/internal/graphql/generate_ts_code.go b/internal/graphql/generate_ts_code.go index c748fd2d0..42a6058f2 100644 --- a/internal/graphql/generate_ts_code.go +++ b/internal/graphql/generate_ts_code.go @@ -447,21 +447,17 @@ func getImportPathForModelFile(nodeData *schema.NodeData) string { func searchForFiles(processor *codegen.Processor) []string { rootPath := processor.Config.GetAbsPathToRoot() - var buf bytes.Buffer cmd := exec.Command("rg", "-tts", "-l", strconv.Quote(strings.Join(searchFor, "|"))) // run in root dir cmd.Dir = rootPath - cmd.Stdout = &buf - cmd.Stderr = os.Stderr - // for debugging... - spew.Dump(strconv.Quote(strings.Join(searchFor, "|"))) - if err := cmd.Run(); err != nil { + b, err := cmd.CombinedOutput() + if err != nil { if processor.Config.DebugMode() { - fmt.Printf("error searching for custom files: %v\n", err) + fmt.Printf("error searching for custom files: %v, output: %s\n", err, string(b)) + return nil } - return nil } - files := strings.Split(strings.TrimSpace(buf.String()), "\n") + files := strings.Split(strings.TrimSpace(string(b)), "\n") result := []string{} From 9fe56c8ddb3b8a76c3f4e11bbd1b984a351bfb2c Mon Sep 17 00:00:00 2001 From: Ola Okelola Date: Mon, 14 Mar 2022 23:56:26 -0700 Subject: [PATCH 3/3] check for exit code 1 which is expected when no results --- internal/graphql/generate_ts_code.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/internal/graphql/generate_ts_code.go b/internal/graphql/generate_ts_code.go index 42a6058f2..e53875659 100644 --- a/internal/graphql/generate_ts_code.go +++ b/internal/graphql/generate_ts_code.go @@ -452,6 +452,11 @@ func searchForFiles(processor *codegen.Processor) []string { cmd.Dir = rootPath b, err := cmd.CombinedOutput() if err != nil { + exit, ok := err.(*exec.ExitError) + // exit code 1 is expected when there's no results. nothing to do here + if ok && exit.ExitCode() == 1 { + return nil + } if processor.Config.DebugMode() { fmt.Printf("error searching for custom files: %v, output: %s\n", err, string(b)) return nil