Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing GPU requirements as optional results in error #833

Closed
sansmoraxz opened this issue Dec 6, 2023 · 1 comment
Closed

Passing GPU requirements as optional results in error #833

sansmoraxz opened this issue Dec 6, 2023 · 1 comment
Labels

Comments

@sansmoraxz
Copy link

What happened?

Passing

    "hostRequirements": {
        "gpu": "optional"
    },

to devcontainer.json results in failure to unmarshall json from string. Logs here:

[22:55:15] info #13 50.68 checking size of wchar_t... 4
[22:51:08] info Workspace d2 already exists
[22:51:09] info Creating devcontainer...
[22:51:12] info devcontainer up: parsing devcontainer.json: json: cannot unmarshal string into Go struct field HostRequirements.hostRequirements.gpu of type bool
[22:51:12] info error parsing workspace info: rerun as root: exit status 1
[22:51:12] error Try enabling Debug mode under Settings to see a more verbose output
[22:51:12] fatal run agent command: Process exited with status 1

What did you expect to happen instead?

As per official specs the hostRequirements.gpu can be string too. In this case it will be best effort ie, fallback to CPU only in case GPU provisioning fails.

How can we reproduce the bug? (as minimally and precisely as possible)

As above.

Local Environment:

  • DevPod Version: v0.4.2
  • Operating System: windows
  • ARCH of the OS: AMD64

DevPod Provider:

  • Cloud Provider: aws
  • Kubernetes Provider: N/a
  • Local/remote provider: ssh
  • Custom provider: provide imported provider.yaml config file: N/a

Anything else we need to know?
N/a

@sansmoraxz sansmoraxz changed the title GPU in optional requirements is not Passing GPU requirements as optional results in error Dec 6, 2023
@pascalbreuninger
Copy link
Member

@sansmoraxz thanks for reporting this issue, we'll adjust the type #836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants