Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Edge to Edge support. #50

Closed
a-eid opened this issue Jun 30, 2024 · 3 comments
Closed

Android Edge to Edge support. #50

a-eid opened this issue Jun 30, 2024 · 3 comments

Comments

@a-eid
Copy link

a-eid commented Jun 30, 2024

Sheet doesn't seem to run in edge to edge mode on android even though my app does.
so basically I am able to draw content below the android Navigation bar, however the sheet footer avoids that by default.

the sheet it self seem to be drawing under the NaviationBar, but not the FooterComponent.

@lodev09
Copy link
Owner

lodev09 commented Jun 30, 2024

Can you create a reproducible example? Handling position in android was a pain, might need to add some conditions when edge-to-edge is enabled. Haven't tried that yet.

@a-eid
Copy link
Author

a-eid commented Jul 2, 2024

Can you create a reproducible example? Handling position in android was a pain, might need to add some conditions when edge-to-edge is enabled. Haven't tried that yet.

will do

@lodev09
Copy link
Owner

lodev09 commented Jul 4, 2024

I'm going to close this and reference it all on #56. Footer in android right now needs work -- it's a bit hacky and I'm not really happy about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants