Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hook_install #824

Open
finnlewis opened this issue Feb 13, 2025 · 2 comments
Open

Remove hook_install #824

finnlewis opened this issue Feb 13, 2025 · 2 comments

Comments

@finnlewis
Copy link
Member

@ekes mentioned that in order to install from config, we need to remove the hook_install from the profile.

https://github.com/localgovdrupal/localgov/blob/3.x/localgov.install#L17-L38

Where should we move this to?

@rupertj
Copy link
Member

rupertj commented Feb 14, 2025

The two parts setting the default homepage would go nicely with #823.

I'd put the part commented "Enable entity_usage for media by default." in localgov_core or maybe its submodule localgov_media.

@ekes
Copy link
Member

ekes commented Feb 18, 2025

The homepage would nicely be replaced by the same sort of generate a homepage and set it behaviour that Microsites has.

I'd put the part commented "Enable entity_usage for media by default." in localgov_core or maybe its submodule localgov_media.

Hmmm... maybe a hook_modules_installed so at any time entity_usage is installed in auto configures it, the profile will install it; but it doesn't require entity_usage because it's not to say that it's the solution used by everyone (there was discussion about different media tracking). Ohh... It's paragraphs that actually requires it (profile just gets it incidentally because of that)

❯ rg "drupal\/entity_usage" web
web/modules/contrib/localgov_paragraphs/composer.json
13:        "drupal/entity_usage": "^2.0@beta",

web/modules/contrib/paragraphs/composer.json
19:    "drupal/entity_usage": "2.x-dev",

web/modules/contrib/layout_paragraphs/composer.json
23:    "drupal/entity_usage": "2.x-dev",

It could even go in there! But hook_modules_installed in localgov_media might make more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants