Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement streaming API #13

Closed
lino-levan opened this issue May 16, 2023 · 5 comments · Fixed by #14
Closed

Implement streaming API #13

lino-levan opened this issue May 16, 2023 · 5 comments · Fixed by #14

Comments

@lino-levan
Copy link
Collaborator

This uses EventSource, so we'll probably have to use Skye's polyfill until denoland/deno#14730 lands.

@daimajia
Copy link

daimajia commented May 24, 2023

Hi @lino-levan Thanks for your working on this project. About the EventSource, do this https://deno.land/x/eventsource@v0.0.3 project works in api streaming?

update: i get it. we are saying the same thing. Looking forward to supporting streaming api.

@ChuckJonas
Copy link
Contributor

In the meantime, maybe consider removing the "stream" option from the API interface?

Just wasted quite a bit of time thinking my code handling the stream was buggy, when really this library just crashes if you set stream:true in the options...

@lino-levan
Copy link
Collaborator Author

I'll make a PR today. Sorry for the trouble!

@daimajia
Copy link

How is the progress?

@lino-levan
Copy link
Collaborator Author

Sorry for the delay, didn't get around to doing it yesterday. PR is open now, waiting on a review from @load1n9 to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants