From 8222637159dc98f003f1e70f183dc11fc81e6b48 Mon Sep 17 00:00:00 2001
From: Rob Suderman <suderman@google.com>
Date: Sun, 21 Apr 2024 09:32:18 -0700
Subject: [PATCH] [onnx] Extend op version number of `onnx.ScatterElements`
 (#3195)

Version number was set too high. Lowered to support more cases allows
more tests to pass.

Co-authored-by: Robert Suderman <rsuderman@Roberts-MacBook-Pro.local>
---
 lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp | 2 +-
 projects/pt1/e2e_testing/xfail_sets.py                | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp b/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp
index 8f6788620018..65bfb6257774 100644
--- a/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp
+++ b/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp
@@ -478,7 +478,7 @@ void mlir::torch::onnx_c::populateDefaultDomainQtoZ(
                   return success();
                 });
   patterns.onOp(
-      "ScatterElements", 18,
+      "ScatterElements", 1,
       [](OpBinder binder, ConversionPatternRewriter &rewriter) {
         Torch::ValueTensorType resultType;
         SmallVector<Value> valList;
diff --git a/projects/pt1/e2e_testing/xfail_sets.py b/projects/pt1/e2e_testing/xfail_sets.py
index ec4d3a8daa20..68fdbb961b26 100644
--- a/projects/pt1/e2e_testing/xfail_sets.py
+++ b/projects/pt1/e2e_testing/xfail_sets.py
@@ -2647,10 +2647,7 @@
     "ScatterReduceIntMinModuleIncludeSelf",
     "ScatterReduceIntProdModuleIncludeSelf",
     "ScatterReduceIntSumModuleIncludeSelf",
-    "ScatterSrcModule_basic",
-    "ScatterSrcStaticModule_basic",
     "ScatterValueFloatModule_basic",
-    "ScatterValueIntModule_basic",
     
     # Failure - onnx_lowering: onnx.ScatterND
     "IndexPut1DFloatAccumulateModule_basic",