From 641026a52a397a168a9a9c4ad8c3eefcb7a8da76 Mon Sep 17 00:00:00 2001 From: Elite Encoder Date: Mon, 13 Feb 2023 03:40:17 -0500 Subject: [PATCH] Removed unnecessary time.sleep, added missing assertion, updated comment --- core/orch_test.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/core/orch_test.go b/core/orch_test.go index a566ffe5b3..66e6c92259 100644 --- a/core/orch_test.go +++ b/core/orch_test.go @@ -429,13 +429,14 @@ func TestRemoveFromRemoteTranscoders_StreamFailover(t *testing.T) { var transcoder_2 = &StubTranscoderServer{manager: rtm} assert.Nil(rtm.liveTranscoders[transcoder_1]) + assert.Nil(rtm.liveTranscoders[transcoder_2]) assert.Empty(rtm.remoteTranscoders) // register 2 transcoders, 8 stream capacity each go func() { rtm.Manage(transcoder_1, 8, capabilities.ToNetCapabilities()) }() - time.Sleep(1 * time.Millisecond) // allow time for first stream to register + time.Sleep(1 * time.Millisecond) // allow time for remote T to connect go func() { rtm.Manage(transcoder_2, 8, capabilities.ToNetCapabilities()) }() - time.Sleep(1 * time.Millisecond) // allow time for second stream to register + time.Sleep(1 * time.Millisecond) // allow time for remote T to connect //Validate two transcoders exist assert.NotNil(rtm.liveTranscoders[transcoder_1]) @@ -446,7 +447,6 @@ func TestRemoveFromRemoteTranscoders_StreamFailover(t *testing.T) { for i := 0; i < 8; i++ { testSessionId := fmt.Sprintf("%s%d", "testID", i) rtm.selectTranscoder(testSessionId, nil) - time.Sleep(1 * time.Millisecond) // allow time for second stream to register } t1 := rtm.liveTranscoders[transcoder_1] @@ -465,7 +465,6 @@ func TestRemoveFromRemoteTranscoders_StreamFailover(t *testing.T) { for i := 0; i < 8; i++ { testSessionId := fmt.Sprintf("%s%d", "testID", i) rtm.selectTranscoder(testSessionId, nil) - time.Sleep(1 * time.Millisecond) // allow time for second stream to register } t1 = rtm.liveTranscoders[transcoder_1]