Skip to content
This repository was archived by the owner on Feb 17, 2021. It is now read-only.

properly catch exceptions caused by illegal targets, fixes #93 #94

Merged
merged 1 commit into from
Jun 16, 2014

Conversation

yeah
Copy link
Contributor

@yeah yeah commented Jun 2, 2014

No description provided.

@timlindvall timlindvall added this to the 0.2.2 milestone Jun 5, 2014
@timlindvall
Copy link
Contributor

Thanks for submitting the pull request. This change looks good to me.

#90 and this PR affect the same code, so whichever one we pull in might cause a merge conflict. Would you be able to update this PR after we pull in #90, if necessary?

@yeah
Copy link
Contributor Author

yeah commented Jun 6, 2014

yeah sure :)

@kate2753
Copy link
Contributor

I've pulled in #90 prefer jQuery and Sizzle over document.querySelector. However, change in this PR is still useful in case jQuery\Sizzle is not available on page and document.querySelector throws an exception. @yeah could you please update a this PR, so we can pull it in?

@yeah
Copy link
Contributor Author

yeah commented Jun 15, 2014

done :)

kate2753 added a commit that referenced this pull request Jun 16, 2014

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Catch exceptions caused by illegal selectors with document.querySelector
@kate2753 kate2753 merged commit e5f3892 into LinkedInAttic:master Jun 16, 2014
@kate2753 kate2753 mentioned this pull request Jun 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants