Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email/Query Pagination 1 - handle pagination with position #3731

Closed
remk opened this issue Sep 1, 2020 · 1 comment
Closed

Email/Query Pagination 1 - handle pagination with position #3731

remk opened this issue Sep 1, 2020 · 1 comment
Labels
1 Story points remaining to complete an issue
Milestone

Comments

@remk
Copy link
Member

remk commented Sep 1, 2020

WHY

As a client I want to be able to get a long list of results in several operations.
As a client i want to be able to start fetching the result only since a given index.

On this ticket we will only consider positive position.


    position: Int (default: 0) The zero-based index of the first id in the full list of results to return.

    If a negative value is given, it is an offset from the end of the list. Specifically, the negative value MUST be added to the total number of results given the filter, and if still negative, it’s clamped to 0. This is now the zero-based index of the first id to return.

    If the index is greater than or equal to the total number of objects in the results list, then the ids array in the response will be empty, but this is not an error.
request
    [[ "Email/query",{
      "accountId": "ue150411c",
      "position": 5
    }, "0" ]]

HOW

  • accept a 'position' parameter in the query request.

DOD

  • write an integration test demonstrating that when the client provide a position parameter, only the result since this position are returned in the response.

  • write an integration test demonstrating that if the client provide a position parameter bigger than the total number of results then the response is empty and there is no error.

  • run the tests against the distributed version of the contract

@chibenwa chibenwa added this to the Sprint 2 milestone Sep 3, 2020
@remk remk self-assigned this Sep 21, 2020
@remk
Copy link
Member Author

remk commented Sep 21, 2020

PR : #3796

@chibenwa chibenwa linked a pull request Sep 22, 2020 that will close this issue
@chibenwa chibenwa reopened this Sep 23, 2020
@chibenwa chibenwa added the 1 Story points remaining to complete an issue label Sep 23, 2020
@Arsnael Arsnael closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Story points remaining to complete an issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants