Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent logging - cli.c doe snot use the logging macros #106

Closed
2 tasks
nirs opened this issue Dec 6, 2024 · 0 comments · Fixed by #109
Closed
2 tasks

Inconsistent logging - cli.c doe snot use the logging macros #106

nirs opened this issue Dec 6, 2024 · 0 comments · Fixed by #109
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nirs
Copy link
Member

nirs commented Dec 6, 2024 •
edited
Loading

In main.c we use the logging macros (DEBUG[F], ERROR[F]), but in cli.c we log using fprintf. This creates inconsistent output like:

  WARNING: --vmnet-gateway=IP should be explicitly specified to avoid conflicting with other applications
  ERROR| WARNING: Running without root. This is very unlikely to work: See README.md
  ERROR| bind: Address already in use
  ERROR| socket_bindlisten: Address already in use

Tasks:

  • Move the logging macros to log.h
  • Use macros from log.h for all logs
@nirs nirs added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 6, 2024
@nirs nirs mentioned this issue Dec 6, 2024
Closed
@AkihiroSuda AkihiroSuda mentioned this issue Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add log.h AkihiroSuda/socket_vmnet
1 participant
@nirs