-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional support for Virtualization.framework (on macOS 13) #889
Comments
Would it make the code harder to support, when having two "drivers" ? Similar to when adding virtfs in addition to sshfs, with many Mac-only issues. |
I think it obviously would, but I think the performance improvements we should be able to get from it would make it worthwhile. |
I just learned that on macOS Ventura you can register Rosetta2 as a binfmt_misc handler inside a VM running in arm64 mode. That should mean that instead of using qemu-static emulation we should be able to run amd64 containers "compiled" into arm64, which should provide a big speed boost for code that is not available natively for arm64 (like mssql): |
This can only be implemented in Swift/Obj-C, right? |
Probably yes, but there is a Go wrapper for the objc |
I have been working on Am happy to extend my support/contribute over here as well :-) Currently i have been working on setting up a slirp like network for virtualization API (facing some challenges here). |
I think it would be great if you could contribute here instead of working on a fork/redo; that way we can all work together... Same way I would like to see required changes to https://github.com/Code-Hex/vz be submitted upstream instead of creating a fork like https://github.com/mac-vz/vz. Forking should really only be a last resort if cooperations turns out to be impossible. Just start a discussion first before working on large PRs, so we all have agreement how things should go forward. One important feature would be that VZ support needs to be optional; it isn't available on Linux (and Windows, if that becomes a thing), and also not on macOS Catalina, which we want to continue to support. Also for some people it will be important that we support a fully open source virtualization implementation, even on a proprietary OS. |
Sure. Am more than happy to work together :-) I went ahead with fork as i wanted to try few variations first. As you said, the goal was to submit to upstream once finalised/stable. I will start a discussion with a bit detailed plan of what i had in mind. From there we can take it forward once all in agreement. |
This could either use something simple, like the 9p vs sshfs. Or it could use something fancy, like the gRPC in docker-machine As long as all "drivers" are provided with lima, I don't see the need for adding the complexity of having stand-alone binaries ? |
@afbjorklund I have opened a discussion #923 covering packaging drivers within lima (Like you said). And also added the complication in doing that and added models on how we can overcome those. |
IMO we need one set of binaries for macOS that works for any supported OS version (well, one set for Intel, and one set for ARM). It is also not clear to me if parts of the Will take a look at #923 tomorrow. |
vz itself will not require root. Just signing binary with com.apple.security.virtualization entitlement is sufficient. Example Except for using bridge network we need to run as root or vmnet entitlement should be added |
The I would be happy to learn that I'm mistaken on this. |
@jandubois The socket_vmnet explains that well, But as you said, if we intend to use bridge network in vz (this is optional there are other network models as well, https://developer.apple.com/documentation/virtualization/network), then yes we should run as a root (assuming we will not sign binaries with valid certificate from Apple) |
Yes, but only virtualization software providers that distribute their software through the Appstore can get it, which is not an option for us, I think. It exists only to provide the capability to sandboxed applications that cannot run as root. Applications distributed outside the app store are supposed to just require root. |
The current discussion has moved to: |
Linking the PR (Thanks to @balajiv113) |
macOS 13 version of Virtualization.framework seems to support UEFI, so we may consider supporting Virtualization.framework in addition to QEMU.
EDIT: The current discussion has moved to:
The text was updated successfully, but these errors were encountered: