Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnrpc: update protoc invocation #169

Merged
merged 1 commit into from
Mar 27, 2017
Merged

lnrpc: update protoc invocation #169

merged 1 commit into from
Mar 27, 2017

Conversation

tmc
Copy link
Contributor

@tmc tmc commented Mar 27, 2017 •
edited
Loading

This commit reflects an upstream change in grpc-gateway. For cloud.google.com/go compatibility grpc-gateway no longer ships go output for {annotations,http}.proto. This renders the "=M" mapping unnecessary.

  • regenerate proto output
  • add genprotos dep, updated glide deps

@mention-bot
Copy link

@tmc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Roasbeef, @BitfuryLightning and @bryanvu to be potential reviewers.

@tmc tmc mentioned this pull request Mar 27, 2017
Closed
@tmc
lnrpc: update protoc invocation
ca294cb 
This commit reflects an upstream change in grpc-gateway.

- regenerate proto output
- add genprotos dep, updated glide deps
@tmc tmc changed the title update protoc invocation, regenerate proto output, update glide deps lnrpc: update protoc invocation Mar 27, 2017
@coveralls
Copy link

coveralls commented Mar 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.039% when pulling ca294cb on tmc:update_protoc into 505421d on lightningnetwork:master.

@coveralls
Copy link

coveralls commented Mar 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.039% when pulling ca294cb on tmc:update_protoc into 505421d on lightningnetwork:master.

This was referenced Mar 27, 2017
Closed
Closed
Roasbeef
Roasbeef approved these changes Mar 27, 2017
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the protoc update! I wasn't aware of this change.

As a result of this change, our gen_protos.sh script is now much cleaner and it also addresses a minor pain point we had within installations due to the script referencing a relative path.

LGTM 🎉

@Roasbeef Roasbeef merged commit d24ca76 into lightningnetwork:master Mar 27, 2017
@tmc tmc deleted the update_protoc branch March 27, 2017 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmc @mention-bot @coveralls @Roasbeef