Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return payment address when adding hold invoices #4820

Closed
alexbosworth opened this issue Dec 3, 2020 · 1 comment · Fixed by #5533
Closed

Return payment address when adding hold invoices #4820

alexbosworth opened this issue Dec 3, 2020 · 1 comment · Fixed by #5533
Labels
enhancement Improvements to existing features / behaviour feature request Requests for new features gRPC hodl-invoices invoices

Comments

@alexbosworth
Copy link
Contributor

Background

In pull request 4752 the payment address secret was added to the response of invoices added

However there is another way to add invoices, which is the add hold invoice API, and to be consistent this should return the payment address as well

Currently this method in the invoices sub-server only returns the payment request in its result.

A workaround would be to lookup the invoice and retrieve the payment address that way.

@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour feature request Requests for new features gRPC hodl-invoices invoices labels Jan 18, 2021
@ErikEk
Copy link
Contributor

ErikEk commented Jul 17, 2021

I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour feature request Requests for new features gRPC hodl-invoices invoices
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants