Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between coop close and force-close in Balance #2738

Closed
TheBlueMatt opened this issue Nov 16, 2023 · 4 comments · Fixed by #3212
Closed

Differentiate between coop close and force-close in Balance #2738

TheBlueMatt opened this issue Nov 16, 2023 · 4 comments · Fixed by #3212
Assignees
@TheBlueMatt
Milestone
0.1

Comments

@TheBlueMatt
Copy link
Collaborator

There is no way to tell whether a Balance is for a coop close or an HTLC or a force-close. We should expose that info.
@TheBlueMatt TheBlueMatt self-assigned this Nov 16, 2023
@TheBlueMatt TheBlueMatt mentioned this issue Nov 16, 2023
Closed
@moneyball
Copy link
Contributor

119 worthy?

@benthecarman benthecarman mentioned this issue Nov 17, 2023
Merged
@TheBlueMatt TheBlueMatt added this to the 0.0.120 milestone Nov 27, 2023
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.120 , 0.0.121 Jan 9, 2024
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.122, 0.0.123 Mar 18, 2024
@Jasonvdb
Copy link

Jasonvdb commented May 8, 2024

Would be interested in using this in Bitkit

@dunxen
Copy link
Contributor

dunxen commented Jul 11, 2024

I can pick this up tomorrow. I'm not sure it would get in by 124 with some of the other work in progress but will make an attempt 👍

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.124, 0.1 Jul 16, 2024
@TheBlueMatt
Copy link
Collaborator Author

Oh, we may want to just slip this, really we want to expose a lot more info, ala #2618 but I haven't had the time to work on #2618 :(. If you want to pick that up, that'd be huge! It was mostly there just needed tests, which were quite nontrivial....

@dunxen dunxen mentioned this issue Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBlueMatt TheBlueMatt

Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Accuracy fixes and differentiating sources for Balance dunxen/rust-lightning
4 participants
@moneyball @TheBlueMatt @dunxen @Jasonvdb