Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl ToSocketAddrs for Hostname (and possibly other NetAddress variants) #2535

Closed
tnull opened this issue Aug 28, 2023 · 2 comments · Fixed by #2636
Closed

impl ToSocketAddrs for Hostname (and possibly other NetAddress variants) #2535

tnull opened this issue Aug 28, 2023 · 2 comments · Fixed by #2636
Labels
good first issue Good for newcomers

Comments

@tnull
Copy link
Contributor

tnull commented Aug 28, 2023

In #2134 we added the FromStr trait implementation to NetAddress.

As a follow-up it would be nice to also add a ToSocketAddrs implementation to allow easy resolution for our NetAdresses, which would be useful for the Hostname variant in particular.

This would also allow us to get rid of the NetAddress newtype in LDK Node, which currently makes use of ToSocketAddrs (cf. https://github.com/lightningdevkit/ldk-node/blob/a9bb2e9c5b9892213b244bc2fb474a5fe0c76802/src/types.rs#L360-L385).

@slanesuke
Copy link
Contributor

I'll take this one as my first issue if that works?

@tnull
Copy link
Contributor Author

tnull commented Sep 7, 2023

I'll take this one as my first issue if that works?

Sure, go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants