Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+C to copy torrent name / filenames - feature request #20

Closed
btTeddy opened this issue May 9, 2023 · 5 comments · Fixed by #22
Closed

Ctrl+C to copy torrent name / filenames - feature request #20

btTeddy opened this issue May 9, 2023 · 5 comments · Fixed by #22
Assignees

Comments

@btTeddy
Copy link

btTeddy commented May 9, 2023

Any chance to have an option in the config to add a shortcut to copy selected torrent names in the main window and/or file name(s) when files selected in torrent file list

example setting:
CopyName=Ctrl+C

image

@lighterowl lighterowl self-assigned this May 10, 2023
@lighterowl
Copy link
Owner

Thanks for the report.

I chose not to do this as a customisable keyboard shortcut and just use the platform's default "copy key sequence" instead, which means Ctrl-C on Windows and Linux and Command-C on macOS.

I think I have something that works, can you download and test https://github.com/xavery/transgui/suites/12872584095/artifacts/694367702 to see if the changes are OK?

@btTeddy
Copy link
Author

btTeddy commented May 13, 2023

Thanks for the report.

I chose not to do this as a customisable keyboard shortcut and just use the platform's default "copy key sequence" instead, which means Ctrl-C on Windows and Linux and Command-C on macOS.

I think I have something that works, can you download and test https://github.com/xavery/transgui/suites/12872584095/artifacts/694367702 to see if the changes are OK?

It works... almost as expected.

Copying torrent name works exactly as expected - linux.iso is copied
Copying file name not exactly - /path/to/linux.iso is getting copied, instead of just linux.iso`

@lighterowl
Copy link
Owner

OK. The paths now will now be copied relative to the torrent's root without including the save folder name, i.e. you will get file1.txt, file2.txt, folder1/file3.txt etc for multi-file torrents.

The new build is here : https://github.com/xavery/transgui/suites/12886324416/artifacts/695327989

@btTeddy
Copy link
Author

btTeddy commented May 14, 2023

And it works exactly as expected.

Thanks for adding this functionality super fast.

I'm gonna create one more request/bugfix (sorting). Hope you don't mind.

@lighterowl
Copy link
Owner

@Beersteddy Of course I don't, keep 'em coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants