Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Scala port to README.md #613

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Add new Scala port to README.md #613

merged 2 commits into from
Feb 14, 2019

Conversation

ekrich
Copy link
Contributor

@ekrich ekrich commented Feb 14, 2019

No description provided.

@havocp
Copy link
Collaborator

havocp commented Feb 14, 2019

Maybe it would be helpful to explain the difference between the two scala ports; I don't want to do it in a way that makes anyone annoyed, but both of them work with scala.js as in the parens on SHocon right?

@ekrich
Copy link
Contributor Author

ekrich commented Feb 14, 2019

Right now it only supports JVM so I didn't want to say anything that might change in the future. If you go to the page it explains things clearly I hope.

@andreaTP I think you know about sconfig, can you weigh in on the subject?

@andreaTP
Copy link
Contributor

@ekrich I'm really happy to see your effort going on! amazing!

Actually I would need to update information around Shocon:
this is the new correct address: https://github.com/akka-js/shocon
and it supports both Scala.Js and Scala Native.

From my POV sconfig is a port to Scala of Typesafe config while, in fact, shocon is a Scala re-implementation of the HOCON specification with a thin layer of API compatibility.

That said, I'll let you word it appropriately or leave it as proposed by @ekrich , as there are several Scala wrappers with no additional explanation on the differences already.

@ekrich
Copy link
Contributor Author

ekrich commented Feb 14, 2019

@andreaTP Thanks, really appreciate the kind words. Do you want me to update yours in this PR?
@havocp I can add that it is a direct port to Scala of the config library if that makes it more clear.

@andreaTP
Copy link
Contributor

@ekrich as you prefer, appreciated if you do so, otherwise I will follow up! 😄

@ekrich
Copy link
Contributor Author

ekrich commented Feb 14, 2019

@havocp and @andreaTP I decided I'd rather just leave the link for sconfig but made some updates for SHocon. Let me know if they are ok.

@andreaTP
Copy link
Contributor

LGTM thanks for the update!

@havocp havocp merged commit d6023a1 into lightbend:master Feb 14, 2019
@havocp
Copy link
Collaborator

havocp commented Feb 14, 2019

cool thanks for talking it over

@2m 2m added this to the 1.3.4 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants