Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive when eliminating package-private class / object #661

Closed
lrytz opened this issue Sep 9, 2021 · 2 comments
Closed

False positive when eliminating package-private class / object #661

lrytz opened this issue Sep 9, 2021 · 2 comments

Comments

@lrytz
Copy link
Contributor

lrytz commented Sep 9, 2021

Removing a package private class or object should be allowed.

Test case in https://github.com/lightbend/mima/compare/main...lrytz:package-private-tests?expand=1
@SethTisue
Copy link
Collaborator

@dwijnand was this fully addressed by #583 and/or #683?

@dwijnand dwijnand mentioned this issue Aug 3, 2022
Closed
@dwijnand dwijnand linked a pull request Aug 3, 2022 that will close this issue
Test cases for mixin forwarder and package private class / object #714
Closed
@SethTisue
Copy link
Collaborator

pretty sure it was, so, closing. but see also ensuing discussion at #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@lrytz @SethTisue