You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just skimmed the api documentation [1] and I think you should puralize? the endpoint name for router to api/routers. If there are or will be other endpoints you should also rename them.
Just skimmed the api documentation [1] and I think you should puralize? the endpoint name for router to
api/routers
. If there are or will be other endpoints you should also rename them.A maybe good resource for arguments:
http://www.vinaysahni.com/best-practices-for-a-pragmatic-restful-api
Maybe it's also worth to think about the routers_by_location resource? Just brain storming:
api/bboxes/1/2/3/4
(-1)api/routers?bbox=1,2,3,4
(+1)api/routers?clustered=true
api/routers?clustered=true&stripped=true
I understand that this is a very subjective topic but there are some conventions that most people try to follow and maybe we should try to do so too.
Thanks for your ongoing hard work on the topic! Nice work!!!
Best Regards
Philipp
[1] https://github.com/libremap/libremap-api/blob/master/doc-api.md
The text was updated successfully, but these errors were encountered: