Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transports/noise: Use proto2 #2924

Closed
mxinden opened this issue Sep 21, 2022 · 5 comments
Closed

transports/noise: Use proto2 #2924

mxinden opened this issue Sep 21, 2022 · 5 comments
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted

Comments

@mxinden
Copy link
Member

mxinden commented Sep 21, 2022

Description

Update libp2p-noise to the latest specification change in libp2p/specs#456.

See libp2p/specs#456 (review) for a draft of a unit test to test compatibility. Might be helpful.

Motivation

See libp2p/specs#456.

Are you planning to do it yourself in a pull request?

No
@mxinden mxinden added difficulty:easy help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Sep 21, 2022
@mxinden
Copy link
Member Author

mxinden commented Sep 21, 2022

See libp2p/go-libp2p#1762 for the corresponding change on go-libp2p.

@nloadholtes nloadholtes mentioned this issue Oct 10, 2022
Closed
4 tasks
@nloadholtes
Copy link
Contributor

Hi @mxinden I'm a Python dev who is looking at learning Rust. This is my first time really messing with a Rust project, so early apologies if I miss anything "obvious". 😄

Also, I am new to libp2p (very interested in it, and trying to learn more about it). Any advice/feedback is welcomed. Thank you!

@thomaseizinger thomaseizinger linked a pull request Oct 16, 2022 that will close this issue
transports/noise: Change protobuf files to proto2 #3007
Closed
4 tasks
@drHuangMHT
Copy link
Contributor

Should we close this issue because we are moving towards proto3? @thomaseizinger

@thomaseizinger
Copy link
Contributor

I'll leave that for future maintainers to decide.

@jxs
Copy link
Member

jxs commented Mar 13, 2024

Since libp2p/specs#465 was accepted and #3007 was closed, I'd say it makes sense to also close this one right?

@jxs jxs closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

transports/noise: Change protobuf files to proto2 nloadholtes/rust-libp2p
5 participants
@nloadholtes @jxs @thomaseizinger @mxinden @drHuangMHT