Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify subsystem configuration structure #845

Closed
willscott opened this issue Mar 18, 2020 · 2 comments
Closed

Clarify subsystem configuration structure #845

willscott opened this issue Mar 18, 2020 · 2 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@willscott
Copy link
Contributor

Currently, several subsystems of libp2p (namely autorelay, the DHT, and autonat), are individually configured, and aren't exposed from libp2p with a single mental model.

For instance, we currently have a single option to "EnableAutoRelay", along with a mode "hop vs discovery".

Instead, it might be more understandable to expose options in the following way:

  • HostReachability (default: Discover, options: Discover, Unreachable, Reachable).
  • NATService (default: Off, options: Off, WhenReachable, On)
  • DHTService (default: WhenReachable, options: Off, WhenReachable, On)
@willscott willscott added the kind/enhancement A net-new feature or improvement to an existing feature label Mar 18, 2020
@Stebalien
Copy link
Member

  • NATService (default: Off, options: Off, WhenReachable, On)
  • DHTService (default: WhenReachable, options: Off, WhenReachable, On)

I believe we can actually simplify both of these to "off" or "on" where "on" always means "when reachable". Then it's up to the user to specify "reachable", "unrachable", "detect".

@willscott
Copy link
Contributor Author

The configuration for these has continued to evolve. closing this issue as obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants