Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move circuitv2 and relay packages #1177

Closed
marten-seemann opened this issue Sep 7, 2021 · 3 comments
Closed

move circuitv2 and relay packages #1177

marten-seemann opened this issue Sep 7, 2021 · 3 comments

Comments

@marten-seemann
Copy link
Contributor

This doesn't really belong in host, that's for host implementations. "relay" is there because it used to be a host wrapper (it really should move).

Maybe move both to a "relay" directory? Really, the "relay" belongs in some form of "relay" package, and the "client" part belongs in a "transports" package, but we don't need to get too fancy.

Originally posted by @Stebalien in #1174 (comment)

@vyzo
Copy link
Contributor

vyzo commented Sep 10, 2021

We should have it in protocol I think, it doesn't belong in host and we don't need a separate package for this.

@vyzo
Copy link
Contributor

vyzo commented Sep 10, 2021

Note that relay contains the autorelay code, it should probably be renamed as such and maybe move into protocol as well.

@marten-seemann
Copy link
Contributor Author

This should have been resolved since v0.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants