Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

Use Postgres #8

Merged
merged 12 commits into from
May 1, 2019
Merged

Use Postgres #8

merged 12 commits into from
May 1, 2019

Conversation

thewilkybarkid
Copy link
Contributor

No description provided.

@@ -1,17 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be useful to continue to populate the dev environment with data.

"time": "2019-02-06T13:18:04+00:00"
},
{
"name": "doctrine/doctrine-cache-bundle",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be an unused hard dependency of doctrine/doctrine-bundle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$schemaProvider = new Definition(StubSchemaProvider::class);
$schemaProvider->setArgument(0, $schema);

$diffCommand->setArgument(0, $schemaProvider);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to not be an existing way to configure the diff command when not using the ORM. Some of these can be moved into the ContentApiBundle; will open a PR on DoctrineMigrationsBundle to add a setting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewilkybarkid thewilkybarkid marked this pull request as ready for review May 1, 2019 10:15
@thewilkybarkid thewilkybarkid requested a review from a team as a code owner May 1, 2019 10:15
- db
db-schema:
<<: *app
command: >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another option for doctrine:migrations:migrate is to execute it as part of app's command so that it doesn't start until there is a database ready for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 a74250b

@thewilkybarkid thewilkybarkid merged commit 7a7895d into libero:master May 1, 2019
@thewilkybarkid thewilkybarkid deleted the postgres branch May 1, 2019 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants