Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution Docs #37

Closed
wants to merge 7 commits into from
Closed

Conversation

rule-of-3
Copy link

Here we aim to create a new part of the CPR docs, aimed at (prospective) contributors. This is not intended to be an exhaustive reference of the library functions, classes and templates, but an overview and explanation of the project's structure and design philosophy.

A new part of the docs has been added, contribution.md, which aims to
ease the way towards contributing to cpr by offering an introduction to
the project. A basic intro and guide for making test/debug builds has
been added.
A first version for various subchapter has also been added.
@rule-of-3 rule-of-3 marked this pull request as ready for review April 3, 2023 15:31
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really promising. Thanks!

Here are a few comments from my side.

rule-of-3 and others added 2 commits April 5, 2023 14:17
Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
@rule-of-3
Copy link
Author

rule-of-3 commented Apr 5, 2023

Thank you very much for going through the text so thoroughly and giving this feedback! It's obvious that I'm still getting the hang of writing docs, but it shouldn't take long!

There's some more ideas that I think may be useful and intend to include, and I'm also trying to get ideas to make it a bit less wall-of-text looking.
This was the intention behind including the links to the master branch headers, so that the reader can be jumping to see some code while they're reading it. It would be quite nice to have links to specific function declarations/ signatures, too, but as far as I know github only allows links to specific lines of code, and they'd fast become irrelevant with commits getting merged to master. This could, of course, be avoided by linking to a specific branch that isn't going to get many changes, such as 1.10.x, but that would generate a bit of overhead to keep it up to date every time the library jumps up a version. So I thought targeting master is a good compromise.

All things considered, I think there's a bit of work to be done till this PR can be considered for merging. Thanks again!

* ctest suggested for running tests, and the executables maintained only
  for gdb debugging.
* Newlines added to improve readability
* references to the library now use the lower-case cpr term

Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
@COM8
Copy link
Member

COM8 commented Apr 15, 2023

Agree. Pointing to specific functions would be awesome, but would require more maintenance. At some point we have to introduce/switch to some partially automated documentation system like doxygen or read the docs. But until then linking to master is totally fine.

@rule-of-3
Copy link
Author

rule-of-3 commented Oct 22, 2024

Sadly, life got in the way and I wasn't able to complete this PR. I won't delete the branch, however, and if anyone wants to use these files or continue it they are free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants