-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution Docs #37
Conversation
A new part of the docs has been added, contribution.md, which aims to ease the way towards contributing to cpr by offering an introduction to the project. A basic intro and guide for making test/debug builds has been added.
A first version for various subchapter has also been added.
de0098e
to
ca32ca3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really promising. Thanks!
Here are a few comments from my side.
Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
Thank you very much for going through the text so thoroughly and giving this feedback! It's obvious that I'm still getting the hang of writing docs, but it shouldn't take long! There's some more ideas that I think may be useful and intend to include, and I'm also trying to get ideas to make it a bit less wall-of-text looking. All things considered, I think there's a bit of work to be done till this PR can be considered for merging. Thanks again! |
* ctest suggested for running tests, and the executables maintained only for gdb debugging. * Newlines added to improve readability * references to the library now use the lower-case cpr term Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
Agree. Pointing to specific functions would be awesome, but would require more maintenance. At some point we have to introduce/switch to some partially automated documentation system like doxygen or read the docs. But until then linking to master is totally fine. |
Sadly, life got in the way and I wasn't able to complete this PR. I won't delete the branch, however, and if anyone wants to use these files or continue it they are free to do so. |
Here we aim to create a new part of the CPR docs, aimed at (prospective) contributors. This is not intended to be an exhaustive reference of the library functions, classes and templates, but an overview and explanation of the project's structure and design philosophy.