Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter function for Session::header_ to enable the user to read back all headers set and delete select ones #1173

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

simue
Copy link
Contributor

@simue simue commented Feb 5, 2025

This PR implements a possible solution to #1172

@COM8 COM8 self-assigned this Feb 5, 2025
@COM8 COM8 added this to the CPR 1.12.0 milestone Feb 5, 2025
@COM8
Copy link
Member

COM8 commented Feb 5, 2025

@simue thanks for contributing! I will try to review it next weekend.

Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two minor things. Thank you very much for submitting this PR!

@COM8 COM8 linked an issue Feb 8, 2025 that may be closed by this pull request
simue and others added 3 commits February 11, 2025 18:45
Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
@simue simue requested a review from COM8 February 11, 2025 17:58
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@COM8 COM8 merged commit dbcdd2f into libcpr:master Feb 12, 2025
44 checks passed
COM8 added a commit that referenced this pull request Feb 17, 2025
Getter function for Session::header_ to enable the user to read back all headers set and delete select ones
@simue simue deleted the feature/delete-header branch February 20, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session: Delete one ore more select headers
2 participants