Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to make safe check to HTMLElement in Common.isElement #459

Closed
Mirodil opened this issue Aug 9, 2017 · 4 comments
Closed

Is it possible to make safe check to HTMLElement in Common.isElement #459

Mirodil opened this issue Aug 9, 2017 · 4 comments
Labels
bug

Comments

@Mirodil
Copy link

Mirodil commented Aug 9, 2017 •
edited
Loading

Hi,

I'm trying to run matter-js in react-native environment and it fields to create Engine object because of this line https://github.com/liabru/matter-js/blob/master/src/core/Common.js#L179-L181 .

is it possible to make it for more safe check to DOM elements?
@liabru
Copy link
Owner

liabru commented Aug 9, 2017

Can you provide the exact error message?

@Mirodil
Copy link
Author

Mirodil commented Aug 9, 2017

here is screenshot:
screen shot 2017-08-09 at 1 41 20 pm

@liabru liabru mentioned this issue Aug 17, 2017
Closed
@liabru liabru added the bug label Aug 17, 2017
@jpagand
Copy link

jpagand commented Oct 2, 2017

FYI this commit added a regression because it was working prior to this
295cffe#diff-b31b513f97c8db0b0c9e3c8f7780b231

@liabru
Copy link
Owner

liabru commented Oct 3, 2017

Ah! Maybe a merge went wrong somewhere then. Thanks for the info.

@almostintuitive almostintuitive mentioned this issue Oct 12, 2017
Closed
@liabru liabru closed this as completed in 18a0845 Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liabru @Mirodil @jpagand