Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most Commands that use indexing do not display correct error message for overflowed maximum integers #3

Open
lfrostbytee opened this issue Nov 11, 2022 · 1 comment

Comments

@lfrostbytee
Copy link
Owner

lfrostbytee commented Nov 11, 2022

  1. Steps to reproduce:
  • Enter the command "grade 10 g/English"

  • Notice that the correct error message is outputted. This is what is expected.

image.png

  • Enter the command "grade 102302130213021302130213021302130213203203210 g/English"

  • Notice that the wrong error message is outputted. This is what is actually seen.
    image.png

  • Can be reproduced on other commands that use indexing such as lesson
    image.png

  • Can also be reproduced on commands that have internal indexing in their parameters like edit

image.png

@lfrostbytee lfrostbytee changed the title Grade command does not display correct error message for overflowed maximum integers Commands that use indexing do not display correct error message for overflowed maximum integers Nov 11, 2022
@lfrostbytee lfrostbytee changed the title Commands that use indexing do not display correct error message for overflowed maximum integers Most Commands that use indexing do not display correct error message for overflowed maximum integers Nov 11, 2022
@nus-se-bot
Copy link

nus-se-bot commented Nov 14, 2022

Team's Response

As mentioned in the module website specifically regarding integer overflow, this is a case of extreme user behaviour which should not be considered a bug. Furthermore, such an input does not cause harm to the app (does not crash or corrupt any data), hence we will reject it.

image.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants