Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Rust target should support the 'workers' and 'threading' target properties #991

Closed
cmnrd opened this issue Mar 2, 2022 · 1 comment · Fixed by #1098
Closed

The Rust target should support the 'workers' and 'threading' target properties #991

cmnrd opened this issue Mar 2, 2022 · 1 comment · Fixed by #1098
Assignees
Labels
enhancement Enhancement of existing feature rust Related to the Rust target
Milestone

Comments

@cmnrd
Copy link
Collaborator

cmnrd commented Mar 2, 2022

Currently, the Rust target uses its own custom mechanism for selecting the threaded and unthreaded runtime. Also, the Rust target does not use the current threads property to configure the number of worker threads. Once #290 is fixed, we should also align the Rust target to support the newly introduced workers and threading properties.

@cmnrd cmnrd added enhancement Enhancement of existing feature rust Related to the Rust target labels Mar 2, 2022
@cmnrd cmnrd added this to the 0.2.0 milestone Mar 2, 2022
@cmnrd
Copy link
Collaborator Author

cmnrd commented Mar 2, 2022

It turns out that the threads property was already supported by the code generator and runtime. However, it was never tested and in fact the threads target property was not enabled for Rust. #993 renames the property to workers. However, we should revisit the change and add tests. Also support for the threading property is still needed.

@cmnrd cmnrd linked a pull request Apr 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature rust Related to the Rust target
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants