Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors from the TS type checker in the examples category #405

Closed
lhstrh opened this issue Jul 12, 2021 · 1 comment
Closed

Catch errors from the TS type checker in the examples category #405

lhstrh opened this issue Jul 12, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lhstrh
Copy link
Member

lhstrh commented Jul 12, 2021

Currently, examples are only validated, not build. This means that certain errors (like type errors unveiled by running tsc) remain hidden.

@lhstrh lhstrh added the bug Something isn't working label Jul 12, 2021
@lhstrh lhstrh added this to the 0.1.0 RC1 milestone Jul 12, 2021
@lhstrh lhstrh self-assigned this Jul 12, 2021
@lhstrh
Copy link
Member Author

lhstrh commented Mar 1, 2022

The reason for this, however, is that it's not always straightforward to build examples due to complicated dependencies and possible platform dependence. We can tailor our testing to examples once we have factored them out into their own repository, which is what we should prioritize instead of fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant