Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show reaction names in diagrams #1856

Closed
lhstrh opened this issue Jun 19, 2023 · 2 comments · Fixed by #2030
Closed

Show reaction names in diagrams #1856

lhstrh opened this issue Jun 19, 2023 · 2 comments · Fixed by #2030
Assignees
@cmnrd @lhstrh @oowekyala @a-sr
Labels
diagrams Problems with diagram synthesis enhancement Enhancement of existing feature
Milestone
0.6.0

Comments

@lhstrh
Copy link
Member

lhstrh commented Jun 19, 2023 •
edited by cmnrd
Loading

After merging #1853, I suggest that we deprecate the @label attribute and instead use the name given in the declaration (if there is one). The code generators can also benefit from this and make the generated code more readable by making use of this.
@lhstrh lhstrh mentioned this issue Jun 19, 2023
Merged
5 tasks
@cmnrd cmnrd added this to the 0.6.0 milestone Jun 21, 2023
@petervdonovan petervdonovan removed their assignment Aug 25, 2023
@cmnrd
Copy link
Collaborator

cmnrd commented Sep 20, 2023

The reaction name should also be shown in the diagrams (instead of the current label).

@cmnrd cmnrd changed the title Deprecate @name and use reaction name in generated code Deprecate @label and use reaction name in generated code Sep 21, 2023
This was referenced Sep 21, 2023
Closed
Closed
@cmnrd cmnrd added enhancement Enhancement of existing feature diagrams Problems with diagram synthesis labels Sep 27, 2023
@cmnrd cmnrd changed the title Deprecate @label and use reaction name in generated code Show reaction names in diagrams Sep 27, 2023
@cmnrd
Copy link
Collaborator

cmnrd commented Sep 27, 2023

Since we decided to keep the @label attribute (see discussion in #2016), this issue only requires displaying the reaction names in the diagrams in order to be fixed.

@cmnrd cmnrd mentioned this issue Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmnrd cmnrd

@lhstrh lhstrh

@oowekyala oowekyala

@a-sr a-sr

Labels
diagrams Problems with diagram synthesis enhancement Enhancement of existing feature
Projects
None yet
Milestone
0.6.0
5 participants
@cmnrd @lhstrh @oowekyala @a-sr @petervdonovan