Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code generation for after is broken #134

Closed
cmnrd opened this issue Apr 1, 2020 · 2 comments
Closed

Code generation for after is broken #134

cmnrd opened this issue Apr 1, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cmnrd
Copy link
Collaborator

cmnrd commented Apr 1, 2020

While trying to implement code generation for the after keyword in C++, I realized that the code generation process is broken after the latest commits. The bodies of the two generated reactions are always empty. I assume this is because generateDelayBody() and generateForwardBody() produce a String, whereas the grammar now defines code as a series of tokens.

This problem did not show up in the tests because the generated reactors still compile and execute, but no data is delivered over the delayed connection and, therefore, no reactions are triggered. I think we will need a more complex test system, which validates the output of tests to find such errors in the future.

@cmnrd cmnrd added the bug Something isn't working label Apr 1, 2020
@lhstrh lhstrh self-assigned this Apr 1, 2020
@lhstrh
Copy link
Member

lhstrh commented Apr 1, 2020

A fix is forthcoming.

@cmnrd
Copy link
Collaborator Author

cmnrd commented Apr 3, 2020

Closing as it seems to be fixed by 82208d9

@cmnrd cmnrd closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants