Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine logical execution time (LET) for each reaction based on immediate downstream #1260

Closed
hokeun opened this issue Jun 30, 2022 · 7 comments
Assignees

Comments

@hokeun
Copy link
Member

hokeun commented Jun 30, 2022

Reference suggested by @Soroosh129 :

for (VarRef effect : definition.getEffects()) {

@hokeun hokeun assigned hokeun and unassigned hokeun Jun 30, 2022
@hokeun
Copy link
Member Author

hokeun commented Jun 30, 2022

@Wonseo-C volunteered to work on this task. And I'll be helping him in case he has any questions. @CloverCho for your information.

@hokeun hokeun self-assigned this Jun 30, 2022
@hokeun
Copy link
Member Author

hokeun commented Jun 30, 2022

Assigned to myself because this cannot be assigned to @Wonseo-C as he's not a member of this repo yet.

@Wonseo-C
Copy link
Collaborator

Wonseo-C commented Jul 6, 2022

timer t(0, 100 msec);

logical action a(60 msec):int;
logical action b(40 msec):int;

input x:int;
output y:int;

state count:int(0);

reaction(t) -> y, a, b {=
   	lf_set(y, self->count);
   	self->count++;
	lf_schedule_int(a, 0, 0);
	lf_schedule_int(b, 0, 0);
=}

Look at this pr. #1277.
I fix the code to use Timevalue rather than its magnitude. (advised by @Soroosh129 )

Then, I tried to experiment with getting the minimum delay.
In this code, I get 40 ms in "this.LET"

@Soroosh129
Copy link
Contributor

@Wonseo-C perhaps it would make sense to add some sort of tests for the newly added getLET()?

@Wonseo-C
Copy link
Collaborator

Wonseo-C commented Jul 6, 2022

@Soroosh129 Sure! But I saw that there is some test error for my PR.

CI / py-tests / run (windows-latest) (pull_request)
image

@Soroosh129
Copy link
Contributor

This looks like a transient error in SSL. It should go away with a re-run.

@Wonseo-C
Copy link
Collaborator

The final work is on the #1292.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants