Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn warning for absence of main reactor into an informational message #1113

Closed
edwardalee opened this issue Apr 23, 2022 · 3 comments
Closed
Assignees
Labels
enhancement Enhancement of existing feature good first issue Good for newcomers

Comments

@edwardalee
Copy link
Collaborator

Currently, if you have a .lf file with no main reactor, you get a warning:

WARNING: The given Lingua Franca program does not define a main reactor. Therefore, no code was generated.

This gets flagged as a yellow caution symbol in the IDE. I don't think this should be a warning. It should be reported as "Information", but our ErrorReporter interface does not have support for this. It should be straightforward to extend it, so I'm marking this as a good first issue.

@edwardalee edwardalee added enhancement Enhancement of existing feature good first issue Good for newcomers labels Apr 23, 2022
@cmnrd
Copy link
Collaborator

cmnrd commented Apr 27, 2022

I am wondering what the error reporter should do with the info message, though. Print it to the command line? I think there is no obvious way of showing info messages in an IDE. However, if info messages are always printed to the command line, we could just print them directly, right?

@edwardalee
Copy link
Collaborator Author

Eclipse has an "info" icon that it can put where it puts the warning or error icon in the left margin.

@lhstrh
Copy link
Member

lhstrh commented May 25, 2022

Fixed by @zekailin00 in #1192.

@lhstrh lhstrh closed this as completed May 25, 2022
@lhstrh lhstrh changed the title Warning when there is no main reactor should be Information not Warning Turn warning for absence of main reactor into an informational message May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants