Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to provide any attribute property #1085

Closed
jeffj6123 opened this issue Jul 1, 2020 · 5 comments
Closed

Add config to provide any attribute property #1085

jeffj6123 opened this issue Jul 1, 2020 · 5 comments
Labels
Feature Feature requests/suggestions

Comments

@jeffj6123
Copy link
Contributor

jeffj6123 commented Jul 1, 2020

Ive noticed a few issues that have been raised mainly in regards to accessibility related issues, which seems to be related to adding specific aria attributes to the sliders.

It might be good to add a dictionary of <attribute name, value> config for each slider control. This would let people add whichever properties are necessary for their compliance.

Now im not sure how if this would work for using updateOptions. You say in the documentation this only works for certain config options

@leongersen leongersen added the Feature Feature requests/suggestions label Jul 17, 2020
@leongersen
Copy link
Owner

I think this could be solved by using an update event listener, and changing/setting any attributes on the handles. What aria attributes are you missing? The slider currently implements the WAI-ARIA roles as defined in this spec.

@RihanArfan
Copy link

This issue is a duplicate of #1019

@leongersen
Copy link
Owner

@LeCodeCo Yes, it is. I'll close this one.

@leongersen
Copy link
Owner

Duplicate of #1019

@leongersen leongersen marked this as a duplicate of #1019 May 4, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Feature requests/suggestions
Projects
None yet
Development

No branches or pull requests

3 participants