Action mistakenly closed responded-to issue

[jeffpaul]

We're utilizing your action in our ElasticPress repo since late last week (thanks for the action, it should help us with repo management IMMENSELY!) but over the weekend it appears to have mistakenly closed an issue that the reporter had responded to as expected. I checked the times of when the label was applied and when the reporter replied and they weren't so close in time that things may have gotten mixed up. The only ideas I have on what may have gone awry is that the reporter responded to the issue via email (and potentially via not their primary email) and maybe something in the source here isn't accounting for that? I scanned through the code but couldn't find anything that looked suspect, so I'm hoping you might have a lead on how best to troubleshoot this and ensure its handled in the future... thanks!

[lee-dohm]

Thanks for this report! I'm glad that you've found it useful 😀

That is a curious situation. I'll see if I can dig deeper into it and reproduce the problem 🤔

[lee-dohm]

My current theory on what happened here is that, for whatever reason (outage or other hiccup), the event when the comment was created didn't trigger the workflow to clear the label. Because there is one and only one chance to clear the label, if that event is missed then we will run into this problem.

My current idea is to have a "last chance" check that runs before the close issue pass to catch any missed opportunities to clear the label. Since the close issue pass runs every hour (if people use the recommended workflow), we should clear the label either when the comment is created or on the next hourly pass at the latest.

[jeffpaul]

@lee-dohm that seems most reasonable to me and as best a root cause as I've come up with as well.

[lee-dohm]

Awesome ... thanks for the confirmation 🙇‍♂️

I've started coding up the implementation of the last chance check, but my spare time is fairly sparse right now ... so I don't know when I'll be able to get it published. I hope this isn't causing you too many problems.

[jeffpaul]

No concerns on my end, adding that is really a peace-of-mind sort of thing that gives folks validation that the action does its best to catch all scenarios. The action otherwise seems stable and very worthwhile, thanks for sharing!

[GlassedSilver]

Mighty interested in the fix for this, any update so far? :)