Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a composable for total progress fetching and points calculation #12619

Closed
Tracked by #11722
rtibbles opened this issue Aug 28, 2024 · 2 comments · Fixed by #12621
Closed
Tracked by #11722

Create a composable for total progress fetching and points calculation #12619

rtibbles opened this issue Aug 28, 2024 · 2 comments · Fixed by #12621
Assignees
Labels
DEV: frontend help wanted Open source contributors welcome

Comments

@rtibbles
Copy link
Member

rtibbles commented Aug 28, 2024

Currently total points fetching is handled in vuex state and with an action:

State: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/state/modules/core/index.js#L13
Action: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/state/modules/core/actions.js#L270
Mutations: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/state/modules/core/actions.js#L270 https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/state/modules/core/mutations.js#L21
Getter: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/state/modules/core/getters.js#L21

These should all be replaced by a composable that has a global progress state, and all references for fetching, mutations, and state should go through the composable.

This composable should be added to the core API spec to facilitate import across plugins.

@nathanaelg16
Copy link
Contributor

Hi @rtibbles, I'd like to be assigned this issue.

@rtibbles
Copy link
Member Author

Thank you @nathanaelg16 - you have been assigned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend help wanted Open source contributors welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants