0.16.0 RC1 fails if Samba/Ansible/etc are installed (e.g. with python3-markdown) on the same OS #11895
Comments
|
This bug has been fixed in every version of Python markdown except version 3.0.0 - do you know why this particular package is being pinned to here? |
|
Digging deeper it seems that even for bullseye the latest version of this package should include the bug fix https://packages.debian.org/search?keywords=python3-markdown |
|
Huge thanks @rtibbles as you seem well on the way to solving (-: All I know is these 2 fail with 0.16.0 RC 1...
|
|
Oh, I see from your traceback that 3.4.2 is the installed version? This is even more confusing. |
Yeah. (3.4.1 actually, on Debian 12 Bookworm) |
|
The really annoying thing about this is that we don't use the markdown library at all in Kolibri, so that's why we don't bundle it! If we can't find a way to handle this just by properly pinning dependencies, I have a last ditch workaround in mind. |
|
Very Awesome if markdown pollution can be removed entirely! 🙃 |
|
OK, yes I see what is happening. The version attribute was reintroduced in 3.0.1 then deprecated and then removed, so it is indeed absent in the latest versions. I will implement a fix in Kolibri to handle this. |
|
@holta notice we're not going to do a new release for the 0.15.x branch, so I'm thinking of doing a Debian patched package for this. 0.16.x will be patched "upstream" |
|
@jredrejo 0.15.x should not be needed, thanks: 0.16.x and 0.17.x are sufficient! |
|
0.16.0 RC 2 has a remaining issue: Above logging also pasted in here: |
|
Hi @holta I have replicated this locally, and hopefully fixed it in this Pull Request: #11905 - in about 30 minutes, the assets (including a debian package) for the PR will be posted in a comment, would you be able to download the debian file from there (it will come bundled inside a zip) and test that this resolves the issue you're seeing here? |
|
Send URL to the .deb package if possible? |
|
Sure the link is here: https://github.com/learningequality/kolibri/suites/20912179106/artifacts/1258052959 |
|
Public URL if possible? |
|
I think this should work: https://filebin.net/otp970zkbg94pqav/kolibri_0.16.0rc2.dev0_git.2.gc8476bec-0ubuntu1_all.deb (tested locally) |
|
Above .deb file installs and works ✅ |
|
Fantastic, thanks for verifying - hopefully rc3 will be the winner! |
|
Closed by #11905 |
|
@rtibbles can you take a quick look below, just to make sure everything's good enough with 0.16.0 as attempted via https://github.com/learningequality/kolibri/releases/download/v0.16.0/kolibri_0.16.0-0ubuntu1_all.deb ? Error seems to be: (Is it possible Kolibri 0.16.x does not yet fully support Python 3.12?)
Excerpt from |
|
Kolibri does not support Python 3.12, no. It is explicitly pinned below 3.12: https://github.com/learningequality/kolibri/blob/release-v0.16.x/setup.py#L111 It seems likely we can only do this in 0.17 where we have dropped support for Python 2.7. |
|
Thanks @rtibbles for clarifying. One side effect: Kolibri 0.17.x pre-releases will become popular on Ubuntu 24.04 (Python 3.12) after that is released around "Earth Day" in late April (: Related: |
|
Testing Slack notification |
The spammy emails from kolibri repos seem to be gone for the moment!? Though recurred in recent days: ...after the originals 2 weeks ago: |
|
Can you tell why https://github.com/learningequality/kolibri/releases/download/v0.16.0/kolibri_0.16.0-0ubuntu1_all.deb is failing on Ubuntu 23.10 — as logged in (Does |
|
This seems to be exactly the same error as I had previously fixed, so I am a little mystified how this might be happening. The fix I applied will guarantee that as long as Kolibri is invoked prior to any markdown import that the error should not occur. I am going to ask our QA team to replicate - I assume the same setup of |
|
Thanks @rtibbles (I can ask others to replicate on Ubuntu 23.10 VM's that are essentially instantly created using Multipass, if you need specific diagnostics...) |
|
False Alarm: I spoke with the person installing on Ubuntu 23.10 and he misunderstood the .deb install process, and so miscommunicated his results 😮 I'm asking him to install https://github.com/learningequality/kolibri/releases/download/v0.16.0/kolibri_0.16.0-0ubuntu1_all.deb according to the correct instructions now... |
|
Confirmed that 0.16.0 runs on Ubuntu 23.10 He apologizes for the false report. (He had installed 0.15.12 while erroneously believing he had installed 0.16.0) |
|
Phew, that is a relief! |
Confirmed on both Debian 12 and Ubuntu — here's an example on a Debian 12.5 VM where the Kolibri 0.16.0 RC1 .deb was installed.
Logs below: Hopefully @rtibbles and @jredrejo can tell if a quick fix is possible or not!
Related:
apt install kolibri"Conflicts with the installed package 'python3-markdown'" and additionally: "/usr/bin/kolibri: No such file or directory" — failure occurs e.g. when samba or pipx are in use on Debian 12 or Raspberry Pi OS Bookworm kolibri-installer-debian#131The text was updated successfully, but these errors were encountered: