Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Rails 7.1 -- rename to run_with #133

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

mathieujobin
Copy link
Contributor

@@ -148,13 +148,13 @@ def valid_lock?(lock_info)

class RedisInstance
module ConnectionPoolLike
def with
def run_with
yield self
end
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to offer with? Is there any chance of breaking something?

        def with
          yield self
        end

        def run_with
          yield self
        end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its broken if we keep it. I think it should be just renamed. but the name might not be your favorite..

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mathieujobin

@leandromoreira
Copy link
Owner

@mathieujobin
Copy link
Contributor Author

@leandromoreira how is that coveralls-ruby PR related to this?

@leandromoreira
Copy link
Owner

ohh @mathieujobin I was just linking the issue to give visibility to coveralls people. :)

@leandromoreira leandromoreira merged commit 902f1e0 into leandromoreira:main Jun 15, 2023
@mathieujobin
Copy link
Contributor Author

I see, I should have thought about it ! Thanks for the merge.

Looking forward to the imminent Rails 7.1 release

@DmytroVasin
Copy link

Will this fix be backported to the 1.x version? Are there any intentions to that?

@mathieujobin
Copy link
Contributor Author

@DmytroVasin is there any reason to remain on 1.x with rails 7.1 ?

@DmytroVasin
Copy link

DmytroVasin commented Jan 7, 2024

@mathieujobin
In our project, we sucked with 1.x version because that is the last version that depends on redis (not redis-client)

But I assume that is my problem :)
Thank you!

P.S. Sorry for the long response :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken with Rails 7.1
3 participants