-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Rails 7.1 -- rename to run_with #133
Conversation
@@ -148,13 +148,13 @@ def valid_lock?(lock_info) | |||
|
|||
class RedisInstance | |||
module ConnectionPoolLike | |||
def with | |||
def run_with | |||
yield self | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to offer with
? Is there any chance of breaking something?
def with
yield self
end
def run_with
yield self
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its broken if we keep it. I think it should be just renamed. but the name might not be your favorite..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mathieujobin
@leandromoreira how is that coveralls-ruby PR related to this? |
ohh @mathieujobin I was just linking the issue to give visibility to coveralls people. :) |
I see, I should have thought about it ! Thanks for the merge. Looking forward to the imminent Rails 7.1 release |
Will this fix be backported to the |
@DmytroVasin is there any reason to remain on 1.x with rails 7.1 ? |
@mathieujobin But I assume that is my problem :) P.S. Sorry for the long response :( |
Because rails 7.1 recently introduce
Object#with
https://github.com/rails/rails/commits/main/activesupport/lib/active_support/core_ext/object/with.rb
fixes #132