par(xpd=TRUE) was in the wrong place #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this PR intended to go from your fork to mine? or to USGS-R? |
|
I guess it would make sense to go to mine, since I still have the PR open.... |
|
Yep - that was on purpose! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
par(xpd=TRUE)was being set in draw_legend, but it was outside of the logic that checked if the legend was going to be drawn or not. The par reset was inside that logic so if you did not call legend(), xpd was never reset. Obviously we still need to revisit the problems with changing par here, but this fixes the immediate bug