Call to undefined function sodium_bin2base64

[neguradionisie]

After last update 4.1.0 i got error Call to undefined function sodium_bin2base64() {"exception":"[object] (Error(code: 0): Call to undefined function sodium_bin2base64() at vendor/lcobucci/jwt/src/Encoding/JoseEncoder.php:50) my php version is 7.4.13 and sodium version 1.0.13. If i change sodium version to 1.0.18 everything is fine.

[Slamdunk]

sodium_bin2base64 was in fact first introduced in 1.0.14: jedisct1/libsodium@3f272cb
And first introduced in libsodium-php in 2.0.6: jedisct1/libsodium-php@0e4c821

I'll see if we can require a minimum version for ext-sodium

[Slamdunk]

As I feared, even though ext-sodium version is known to PHP:

$ php -i | grep sodium
sodium
sodium support => enabled
libsodium headers version => 1.0.18
libsodium library version => 1.0.18

$ php -r 'print_r(get_defined_constants(true));' | grep -i sodium | grep -i version
            [SODIUM_LIBRARY_VERSION] => 1.0.18
            [SODIUM_LIBRARY_MAJOR_VERSION] => 10
            [SODIUM_LIBRARY_MINOR_VERSION] => 3

There is no standardization around extension versioning, so composer is unaware of it.
As a result, unfortunately we cannot require the correct version into composer.json.

We could leverage SODIUM_LIBRARY_VERSION constant, but I don't like dynamic checks for extensions.
It's worth a doc update though.

WDYT @lcobucci ?

[SvenRtbg]

Detect with function_exists() and either have an alternative implementation or send a descriptive error message. In theory you could require extension versions in Composer. In practice they act as hidden PHP version requirements, and users are usually unable to update extensions, either because they lack the permissions or their distribution does not have them.

[lcobucci]

I'd add back the old implementation as a new class (legacy encoder?) and put the logic to pick the new or the legacy (or the user provided one) on the config class.

Then we keep the weird stuff in the service locator.

@Slamdunk how does that sound?

[susheelk985]

Error: Call to undefined function sodium_bin2base64() in file vendor/lcobucci/jwt/src/Encoding/JoseEncoder.php on line 50

How to solve this issue?

[Slamdunk]

Either upgrade libsodium or wait for #670 fix to be released

[lcobucci]

Released!