Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X/Y axis are flipped in portrait mode #6

Closed
lazd opened this issue Jan 7, 2020 · 0 comments
Closed

X/Y axis are flipped in portrait mode #6

lazd opened this issue Jan 7, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@lazd
Copy link
Owner

lazd commented Jan 7, 2020 •
edited
Loading

Description

Right now, rotating the screen results in flipped x/y axis for touch interactions.

Steps to reproduce

  1. Open System Preferences
  2. Select Display
  3. Set Rotation to Standard
  4. Tap the screen and drag your finger
  5. Observe that the cursor does not follow your finger, but instead movements affect the opposite axis

Expected behavior

Axes should not be swapped

Environment

  • Computer: Chuwi Minibook 8
  • VoodooI2C version: 2.2
  • VoodooI2CGoodix version: 0.2.1
  • macOS Version: 10.5.2 19C57

Additional context

Looking at the VoodooI2CTouchscreenHIDEventDriver implementation, it is possible to detect if the frame buffer is rotated and adjust accordingly.
@lazd lazd added the bug Something isn't working label Jan 7, 2020
@lazd lazd closed this as completed in 50b24ba Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lazd